dondaum commented on code in PR #56326:
URL: https://github.com/apache/airflow/pull/56326#discussion_r2398785148
##########
providers/atlassian/jira/src/airflow/providers/atlassian/jira/hooks/jira.py:
##########
@@ -19,30 +19,44 @@
from __future__ import annotations
+import json
from typing import Any, cast
+import aiohttp
from atlassian import Jira
from airflow.exceptions import AirflowException
from airflow.providers.atlassian.jira.version_compat import BaseHook
+from airflow.providers.http.hooks.http import HttpAsyncHook
class JiraHook(BaseHook):
"""
Jira interaction hook, a Wrapper around Atlassian Jira Python SDK.
:param jira_conn_id: reference to a pre-defined Jira Connection
+ :param proxies: Proxies to make the Jira REST API call. Optional
+ :param api_root: root for the api requests. Optional
+ :param api_version: Jira api version to use. Optional
"""
default_conn_name = "jira_default"
conn_type = "jira"
conn_name_attr = "jira_conn_id"
hook_name = "JIRA"
- def __init__(self, jira_conn_id: str = default_conn_name, proxies: Any |
None = None) -> None:
+ def __init__(
+ self,
+ jira_conn_id: str = default_conn_name,
+ proxies: Any | None = None,
+ api_root: str = "rest/api",
Review Comment:
Added `api_root` and `api_version` as these can also be set in
`atlassian-python-api`
https://github.com/atlassian-api/atlassian-python-api/blob/master/atlassian/jira.py#L31
https://github.com/atlassian-api/atlassian-python-api/blob/master/atlassian/rest_client.py#L83
https://github.com/atlassian-api/atlassian-python-api/blob/master/atlassian/rest_client.py#L84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
