wind0r commented on code in PR #51792:
URL: https://github.com/apache/airflow/pull/51792#discussion_r2367111440
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -98,12 +98,17 @@ spec:
{{- if $containerLifecycleHooks }}
lifecycle: {{- tpl (toYaml $containerLifecycleHooks) . | nindent 12
}}
{{- end }}
- {{- if .Values.statsd.args }}
- args: {{ tpl (toYaml .Values.statsd.args) . | nindent 12 }}
- {{- else}}
args:
+ {{- if .Values.statsd.args }}
+ {{- range $arg := .Values.statsd.args }}
+ - {{ $arg | quote }}
+ {{- end }}
+ {{- else }}
- "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"
{{- end }}
+ - "--statsd.cache-size={{ .Values.statsd.cacheSize | default 1000
}}"
+ - "--statsd.cache-type={{ .Values.statsd.cacheType | default `lru`
}}"
+ - "--ttl={{ .Values.statsd.ttl }}"
Review Comment:
should a default also be added here? or since all those 3 values are also
defined under values maybe the other 2 default should be dropped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
