bbovenzi commented on code in PR #56030:
URL: https://github.com/apache/airflow/pull/56030#discussion_r2417571387
##########
airflow-core/src/airflow/ui/src/pages/HITLTaskInstances/HITLTaskInstances.tsx:
##########
@@ -99,23 +112,43 @@ const taskInstanceColumns = ({
? []
: [
{
- accessorKey: "task_display_name",
+ accessorKey: "task_id",
cell: ({ row: { original } }: TaskInstanceRow) => (
<TruncatedText text={original.task_instance.task_display_name} />
),
- enableSorting: false,
header: translate("common:taskId"),
},
]),
{
accessorKey: "rendered_map_index",
+ cell: ({ row: { original } }) => <TruncatedText
text={original.task_instance.rendered_map_index ?? ""} />,
header: translate("common:mapIndex"),
},
{
accessorKey: "responded_at",
cell: ({ row: { original } }) => <Time datetime={original.responded_at} />,
header: translate("response.received"),
},
+ {
+ accessorKey: "created_at",
+ cell: ({ row: { original } }) => <Time datetime={original.created_at} />,
+ header: translate("response.created"),
+ },
+ {
+ accessorKey: "responded_by_user_id",
+ cell: ({ row: { original } }) => <TruncatedText
text={original.responded_by_user?.id ?? ""} />,
+ header: translate("response.responded_by_user_id"),
+ },
+ {
+ accessorKey: "responded_by_user_name",
+ cell: ({ row: { original } }) => <TruncatedText
text={original.responded_by_user?.name ?? ""} />,
+ header: translate("response.responded_by_user_name"),
+ },
Review Comment:
Let's just show the user name to start. We can make it a custom cell
component later that includes both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
