o-nikolas commented on code in PR #56013:
URL: https://github.com/apache/airflow/pull/56013#discussion_r2373255526
##########
airflow-core/src/airflow/dag_processing/bundles/manager.py:
##########
@@ -193,6 +193,12 @@ def parse_config(self) -> None:
_add_example_dag_bundle(bundle_config_list)
for bundle_config in bundle_config_list:
+ if bundle_config.team_name and not conf.getboolean("core",
"multi_team"):
+ raise AirflowConfigException(
+ "Section `dag_processor` key `dag_bundle_config_list` "
+ "cannot have a team name when multi team mode is disabled."
Review Comment:
Maybe mention the config they have to set to fix it (i.e. "section `core`
key `multi_team`")
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -509,6 +509,15 @@ core:
type: string
example: ~
default: ~
+ multi_team:
+ description: |
+ Whether to run the Airflow environment in multi-team mode.
+ In this mode, different teams can have isolated access to resources
while still sharing the same
Review Comment:
I don't exactly have a better phrasing as of yet, but I'm slightly worried
that people are going to read too much into isolated. When it's not going to be
bullet proof at first as far as isolation goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
