ralichkov commented on issue #56349: URL: https://github.com/apache/airflow/issues/56349#issuecomment-3366650219
just fyi @atzannes I've only been engaging with k8s for a couple months, but: > what's the difference between termination and deletion? I believe they are the same, with the term varying upon context. > and then I see it being used in def on_kill. What triggers that? Is it when you set 'marked task as failed' from the UI? Yes. That, task failure, timeouts, executor dying, probably other cases of the like. I completely agree with the rest you said. I believe `termination_grace_period` should be set explicitly in the pod spec when it is created, and I'd strip out this `kwargs.update()` stuff in `on_kill()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
