Pyasma opened a new pull request, #56298:
URL: https://github.com/apache/airflow/pull/56298
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Fix: Implement Robust SQLAlchemy URI Construction for PrestoHook
This PR resolves a critical issue where the **`PrestoHook`** failed to
reliably construct a valid SQLAlchemy connection URI. The dependency on the
generic and flawed `DbApiHook.get_uri()` prevented the hook from correctly
translating complex connection parameters required by Presto/Trino.
This change is implemented by **adding the `sqlalchemy_url` property and
updating the `get_uri()` method** to rely on this new, correct logic. This
guarantees compliant URL formatting by:
1. **Correct Path Construction:** Safely builds the mandatory path as
`catalog/schema`.
2. **Parameter Translation:** Ensures essential configuration details (like
`protocol` and `source`) are extracted from the `extra` field and mapped to URL
query parameters.
### Added/Modified Functions
* `sqlalchemy_url` (New property): Constructs the correct SQLAlchemy `URL`
object.
* `get_uri()` (Modified method): Returns the string representation of the
fixed URL.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
### Related Issues
related: #38195 (Specifically Presto portion)
### Checklist
* [x] I have rebased my branch to the latest `main` branch.
* [x] I have run `prek` and all checks passed.
* [x] I have written tests that cover the added `sqlalchemy_url` and
modified `get_uri` methods.
* [x] I have checked my tests cover the fix (verifie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
