potiuk opened a new pull request, #56826: URL: https://github.com/apache/airflow/pull/56826
Apparently the prek cache mechanism has been somewhat broken for a while - after we split prek to monorepo. The hash files used to determine prek-cache was different for save and restore step (the `**/` has been missing in the save cache step. Which means that we always failed to restore cache and created it from the scratch. Also, it seems that the prek cache-when prepared refers to the uv version that is pre-installed for it in case uv is not installed in the system. And it refers to the uv version when creating the virtual environments used by prek, and we first attempted to install prek and create cache, and only after we installed uv, which had a side-effect that in some cases the installed venvs referred to a missing python binary. Finally - there is a bug in prek https://github.com/j178/prek/issues/918 that pygrep cache contains reference to a non-existing python binary that should be run when pygrep runs. Also it's possible that some of the cache installed in workspace by the github worker remained, and we did not preemptively clean the cache when we attempted to restore it and failed. This PR attempts to restore the cache usage in a more robust way: * fixed cache key on save to save cache with proper name * added uv version to cache key for prek * always install uv in desired version before installing prek * if we faile to cache-hit and restore the cache, we clean-up the .cache/prek folder * we do not look at skipped hooks when installing prek and restoring or saving cache. There is very little saving on some hooks and since we are preparing the cache in "build-info" now - it's better to always use the same cache, no matter if some checks are skipped * upgraded to prek 0.2.10 that fixed the issue with pygrep cache (cherry picked from commit 556d179d35be124b81bbb7cadc1e48ac1029ecec) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> <!-- Please keep an empty line above the dashes. --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
