potiuk opened a new pull request, #56829:
URL: https://github.com/apache/airflow/pull/56829
The MyPy checks are slow and they require breeze image to be built, so they
are slowing down commit operations when you have prek installed and your image
is not built or your change contains a number of files and mypy cache is not
warmed up.
Moving mypy checks to pre-push makes it easier to accept by developers to
run `prek install` - and they might also opt-in to use `prek install
--hook-type pre-push` if they want to (by default) run mypy checks when pushing
their changes.
Still - even if you install prek with hook-stage `pre-push` you can skip it
by `git push --no-verify` - same as in case of commit.
This should make "prek" experience quite a bit better for casual usage or
when people are not keeping their breeze image updated.
This should also help in case of cherry-picking, when cherry-picking, and
you need to resolve conflicts, git does not have option to run `cherry-pick
--continue --no-verify` and you need to manually uninstall prek to skip running
prek hooks - which often is slow due to image not being fresh enough and mypy
being generally slow.
This might be quite a QOL improvement for many contributors.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
