xBis7 commented on code in PR #56150:
URL: https://github.com/apache/airflow/pull/56150#discussion_r2395376252
##########
airflow-core/src/airflow/traces/otel_tracer.py:
##########
@@ -138,9 +144,10 @@ def start_span(
links=None,
start_time=None,
):
- """Start a span; if service_name is not given, otel_service is used."""
+ """Start a span."""
if component is None:
- component = self.otel_service
+ # Common practice is to use the module name.
+ component = __name__
Review Comment:
> `component = component or __name__`
One liner, nice!
> here and below: Is this going to be a breaking change?
No, I don't think so. This is used by the visualization backend to group
together, all the spans that belong to the same component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
