karunpoudel commented on code in PR #56228:
URL: https://github.com/apache/airflow/pull/56228#discussion_r2392309872
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/base_azure.py:
##########
@@ -111,22 +119,74 @@ def get_conn(self) -> Any:
self.log.info("Getting connection using a JSON config.")
return get_client_from_json_dict(client_class=self.sdk_client,
config_dict=key_json)
- credentials: ServicePrincipalCredentials |
AzureIdentityCredentialAdapter
+ credentials = self.get_credential(conn=conn)
+
+ return self.sdk_client(
+ credentials=credentials,
+ subscription_id=subscription_id,
+ )
+
+ def get_credential(self, *, conn: Connection | None = None) -> Any:
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]