amoghrajesh commented on code in PR #56503: URL: https://github.com/apache/airflow/pull/56503#discussion_r2431305058
########## providers/amazon/src/airflow/providers/amazon/aws/operators/bedrock.py: ########## @@ -41,8 +41,12 @@ ) from airflow.providers.amazon.aws.utils import validate_execute_complete_event from airflow.providers.amazon.aws.utils.mixins import aws_template_fields +try: + from airflow.sdk.timezone import datetime +except ImportError: + from airflow.utils.timezone import datetime # type: ignore[attr-defined,no-redef] Review Comment: Same comment for all usages ########## providers/amazon/src/airflow/providers/amazon/aws/operators/bedrock.py: ########## @@ -41,8 +41,12 @@ ) from airflow.providers.amazon.aws.utils import validate_execute_complete_event from airflow.providers.amazon.aws.utils.mixins import aws_template_fields +try: + from airflow.sdk.timezone import datetime +except ImportError: + from airflow.utils.timezone import datetime # type: ignore[attr-defined,no-redef] Review Comment: Same comments for all usages ########## providers/amazon/src/airflow/providers/amazon/aws/operators/bedrock.py: ########## @@ -41,8 +41,12 @@ ) from airflow.providers.amazon.aws.utils import validate_execute_complete_event from airflow.providers.amazon.aws.utils.mixins import aws_template_fields +try: + from airflow.sdk.timezone import datetime +except ImportError: + from airflow.utils.timezone import datetime # type: ignore[attr-defined,no-redef] Review Comment: Concur with Tp, can we move this try / except block to L45 instead? ########## providers/amazon/src/airflow/providers/amazon/aws/operators/bedrock.py: ########## @@ -41,8 +41,12 @@ ) from airflow.providers.amazon.aws.utils import validate_execute_complete_event from airflow.providers.amazon.aws.utils.mixins import aws_template_fields +try: + from airflow.sdk.timezone import datetime +except ImportError: + from airflow.utils.timezone import datetime # type: ignore[attr-defined,no-redef] Review Comment: `attr-defined` shouldnt be needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
