rich7420 opened a new pull request, #56418:
URL: https://github.com/apache/airflow/pull/56418
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
related: #56015
How I Fixed It in this PRr
I added the missing logs volume mount to the `wait-for-airflow-migrations`
initContainers in these files:
- chart/templates/scheduler/scheduler-deployment.yaml
- chart/templates/triggerer/triggerer-deployment.yaml
- chart/templates/workers/worker-deployment.yaml
### Test
### Test 1: Reproduce the Original Problem
Grab this values file to mimic the issue:
```yaml
# test-original-issue.yaml
scheduler:
extraVolumeMounts:
- mountPath: /usr/local/airflow/logs
name: airflow-logs
- mountPath: /tmp
name: tmp
extraVolumes:
- emptyDir: {}
name: airflow-logs
- emptyDir: {}
name: tmp
triggerer:
extraVolumeMounts:
- mountPath: /usr/local/airflow/logs
name: airflow-logs
- mountPath: /tmp
name: tmp
extraVolumes:
- emptyDir: {}
name: airflow-logs
- emptyDir: {}
name: tmp
workers:
extraVolumeMounts:
- mountPath: /usr/local/airflow/logs
name: airflow-logs
- mountPath: /tmp
name: tmp
extraVolumes:
- emptyDir: {}
name: airflow-logs
- emptyDir: {}
name: tmp
securityContexts:
containers:
readOnlyRootFilesystem: true
```
Run this to check:
```bash
helm template test-release chart/ -f test-original-issue.yaml | grep -A 25
"wait-for-airflow-migrations"
```
What you should see is all initContainers now have both the standard logs
volume and any extra mounts—no more mismatches.
### Test 2: With Persistence Enabled
Try this values file for persistent logs:
```yaml
# test-persistence.yaml
logs:
persistence:
enabled: true
subPath: "airflow-logs"
```
Check it out:
```bash
helm template test-release chart/ -f test-persistence.yaml | grep -A 25
"wait-for-airflow-migrations"
```
What you should see is InitContainers include the logs volume with the right
`subPath` config.
### Test 3: Just the Basics
No extra bells and whistles—test the default setup:
```yaml
# test-minimal.yaml
# Empty file, basically defaults only
```
Run:
```bash
helm template test-release chart/ -f test-minimal.yaml | grep -A 25
"wait-for-airflow-migrations"
```
Then you should see Every initContainer has the standard logs volume mount,
loud and clear.
## Any Breaking Changes?
Nope, none at all.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
