anshuksi282-ksolves opened a new pull request, #56536:
URL: https://github.com/apache/airflow/pull/56536

   ## Fix: Stable DAG Serialization Hash (Deterministic Ordering)
   This PR fixes a critical issue where DAGs generated unnecessary new versions 
due to non-deterministic JSON ordering during serialization.
   
   ### Key Changes & Verification
   Implemented recursive sorting logic (_sort_serialized_dag_dict) to ensure 
the dag_hash is 100% stable.
   
   Sorting is used only for hash calculation; the original, unsorted data is 
still persisted (addressing reviewer concerns).
   
   All unrelated changes were reverted to keep the PR focused and clean for 
backporting.
   
   The fix is confirmed by the successful unit test output (including the 
previously failing asset dependency test):
   
   ```bash
   
airflow-core/tests/unit/models/test_serialized_dag.py::TestSerializedDagModel::test_get_dag_dependencies_with_all_types[raw-serialized_dags]
 PASSED [ 50%]
   
airflow-core/tests/unit/models/test_serialized_dag.py::TestSerializedDagModel::test_get_dag_dependencies_with_all_types[compress-serialized_dags]
 PASSED [100%]
   ```
   
   ### Result
   Serialization is now deterministic. This reduces unnecessary DB writes and 
improves system reliability.
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to