obarisk commented on code in PR #55110:
URL: https://github.com/apache/airflow/pull/55110#discussion_r2422047484
##########
providers/google/src/airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -2370,20 +2370,13 @@ def execute(self, context: Any):
if self.project_id is None:
self.project_id = hook.project_id
- # Handle missing logical_date. Example: asset-triggered DAGs (Airflow
3)
- logical_date = context.get("logical_date")
- if logical_date is None:
- # Use dag_run.run_after as fallback when logical_date is not
available
- dag_run = context.get("dag_run")
- if dag_run and hasattr(dag_run, "run_after"):
- logical_date = dag_run.run_after
-
self.job_id = hook.generate_job_id(
job_id=self.job_id,
dag_id=self.dag_id,
task_id=self.task_id,
- logical_date=logical_date,
+ logical_date=None,
Review Comment:
at the moment, I didn't drop `logical_date` completely from
`generate_job_id` for backward compatibility.
ref: `providers/google/src/airflow/providers/google/cloud/hooks/bigquery.py`
line 1298.
We need a explict `None` here before we drop `logical_date` from
`generate_job_id`.
ref: https://github.com/apache/airflow/pull/55110#discussion_r2312993976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
