potiuk commented on code in PR #56408: URL: https://github.com/apache/airflow/pull/56408#discussion_r2426717791
########## providers/src/airflow/providers/fab/auth_manager/security_manager/override.py: ########## @@ -19,6 +19,7 @@ import copy import datetime +import importlib Review Comment: We just copy it from FAB here: https://github.com/dpgaspar/Flask-AppBuilder/blob/master/flask_appbuilder/security/manager.py - might be a good idea to open PR there, but generally we try to keep 1-1 on what is in FAB's security manager. The importlib-metadata package is a direct dependency of Airlfow 2 (and fab 1.5 is only for Airflow 2) - so it will be installed for sure. I would not want to deviate from FAB in this respect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
