ashb commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic
imports and pylint disables
URL: https://github.com/apache/airflow/pull/6601#discussion_r348390357
##########
File path: airflow/serialization/serialization.py
##########
@@ -244,8 +245,247 @@ def _value_is_hardcoded_default(cls, attrname, value):
return False
-if TYPE_CHECKING:
- from airflow.serialization.json_schema import Validator
- from airflow.serialization.serialized_baseoperator import
SerializedBaseOperator # noqa: F401, E501; # pylint: disable=cyclic-import
- from airflow.serialization.serialized_dag import SerializedDAG # noqa:
F401, E501; # pylint: disable=cyclic-import
- from inspect import Parameter
+class SerializedDAG(DAG, Serialization):
Review comment:
I'm okay either way (not changing things we don't need to, but also okay
with these all living in one file), though I would marginally prefer it to be
called `airflow.serialization` and not `airflow.serialization.serialization` :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
