anshuksi282-ksolves commented on code in PR #56422:
URL: https://github.com/apache/airflow/pull/56422#discussion_r2436023111
##########
airflow-core/src/airflow/models/serialized_dag.py:
##########
@@ -412,7 +412,7 @@ def write_dag(
serialized_dag_hash = session.scalars(
select(cls.dag_hash).where(cls.dag_id ==
dag.dag_id).order_by(cls.created_at.desc())
).first()
- dag_version = DagVersion.get_latest_version(dag.dag_id,
session=session, load_dag_model=True)
+ dag_version = DagVersion.get_latest_version(dag.dag_id,
session=session, load_serialized_dag=True)
Review Comment:
Thanks for sharing your thoughts! I see where you’re coming from. Just to
clarify, using `session.query(...).limit(1)` is actually the legacy `SQLAlchemy
1.x style`. In `Airflow 3.x / SQLAlchemy 2.x,` the recommended and more
consistent approach is:
```python
dag_version = session.scalars(
select(DagVersion)
.where(
DagVersion.dag_id == dag.dag_id,
DagVersion.bundle_version == bundle_version,
DagVersion.bundle_name == bundle_name,
)
.options(joinedload(DagVersion.task_instances))
.options(joinedload(DagVersion.serialized_dag))
.order_by(DagVersion.created_at.desc())
).first()
```
It’s fully compatible with the modern 2.x style and avoids potential
CI/check failures that come from using legacy `query()` calls.
I understand this is a special case, but I’d recommend keeping the 2.x style
for consistency across the codebase. If needed, we can tweak the `where`
conditions to cover your use case without switching to the legacy API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
