potiuk commented on code in PR #56634:
URL: https://github.com/apache/airflow/pull/56634#discussion_r2435411718
##########
airflow-core/docs/administration-and-deployment/logging-monitoring/metrics.rst:
##########
@@ -75,6 +75,17 @@ Add the following lines to your configuration file e.g.
``airflow.cfg``
otel_interval_milliseconds = 30000 # The interval between exports,
defaults to 60000
otel_ssl_active = False
+.. note::
+
+ To support the OpenTelemetry exporter standard, the ``metrics``
configurations are transparently superseded by use of standard OpenTelemetry
SDK environment variables.
Review Comment:
```suggestion
To support the OpenTelemetry exporter standard, the ``metrics``
configurations are transparently overridden by use of standard OpenTelemetry
SDK environment variables.
```
##########
airflow-core/docs/administration-and-deployment/logging-monitoring/traces.rst:
##########
@@ -43,6 +43,15 @@ Add the following lines to your configuration file e.g.
``airflow.cfg``
otel_ssl_active = False
otel_task_log_event = True
+.. note::
+
+ To support the OpenTelemetry exporter standard, the ``traces``
configurations are transparently superseded by use of standard OpenTelemetry
SDK environment variables.
+
+ - ``OTEL_EXPORTER_OTLP_ENDPOINT`` and
``OTEL_EXPORTER_OTLP_TRACES_ENDPOINT`` supersede ``otel_host``, ``otel_port``
and ``otel_ssl_active``
Review Comment:
```suggestion
- ``OTEL_EXPORTER_OTLP_ENDPOINT`` and
``OTEL_EXPORTER_OTLP_TRACES_ENDPOINT`` overridden ``otel_host``, ``otel_port``
and ``otel_ssl_active``
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
