Lee-W commented on issue #43176:
URL: https://github.com/apache/airflow/issues/43176#issuecomment-3379115417
#### 1. Use `task.short_circuit` when `task.branch` has multiple `return`s
and exactly one of them is not `[]`
* Should we do it?
* Is it a typical case?
* Is it doable?
* Should be
<https://github.com/apache/airflow/issues/43176#issuecomment-2667604469>
#### 2. If `SomeOtherOperator(some_template_field="{{
ti.xcom_pull(task_ids=['task1']) }}")` is used, replace it with `......
some_template_field=task1.output` instead
* Should we do it?
* Sounds good
* Is it doable?
* Possibly
* Need to define the exact list of template_field
<https://github.com/apache/airflow/issues/43176#issuecomment-2667826944>
#### 3. The Dag must not have top-level calls to expensive classes/services.
* Should we do it?
* Sounds good
* Is it doable?
* Possibly
* More detail needed. What are "expensive classes/services"? We need an
exact list to check, and it needs to be generalized enough
> Ensure function-level imports are used in DAG files when possible (again,
an example of this kind of rule may be found in the airflint repo here)
<!--TODO-->
<https://github.com/apache/airflow/issues/43176#issuecomment-2667878168>
<https://github.com/apache/airflow/issues/43176#issuecomment-2669919039>
#### 4. The DAG object should be instantiated using a context manager.
* Should we do it?
* Why? taskflow also works fine?
* Is it doable?
* Should be
<https://github.com/apache/airflow/issues/43176#issuecomment-2667878168>
#### 5. The Dag file name should match its dag_id.
* Is it doable?
* I doubt it's doable
<https://github.com/apache/airflow/issues/43176#issuecomment-2667878168>
#### 6. All `dag_id` s should be unique
* Is it doable?
* Single file. Possible. But will need extra effort to dig into it
* Cross files. Probably not.
<https://github.com/apache/airflow/issues/43176#issuecomment-2669919039>
#### 7. Require Variables passed to operator constructors are only passed as
Jinja templates (per the official best practice section here).
* Should we do it?
* Sounds good
* Is it doable?
* Should be
<https://github.com/apache/airflow/issues/43176#issuecomment-2669919039>
#### 8. it would be really useful if the Airflow linter could validate the
user's DAG code against any user-defined task policy or dag policy
* Is it doable?
* I doubt it's doable
<https://github.com/apache/airflow/issues/43176#issuecomment-2669919039>
#### 9. Optionally check whether DAG definitions are serializable or not
* Is it doable?
* I doubt it's doable
<https://github.com/apache/airflow/issues/43176#issuecomment-2672255689>
#### 10. tmp path not returned by tasks
* Should we do it?
* not sure whether it's a common case
* Is it doable?
* Should be
<https://github.com/apache/airflow/issues/43176#issuecomment-2695069193>
#### 11. Don't allow implicit python task decorators, `@task`, and instead
require specifying `@task.python`.
* Should we do it?
* netural
* Is it doable?
* Should be
<https://github.com/apache/airflow/issues/43176#issuecomment-2737216835>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
