TyrellHaywood commented on code in PR #56371:
URL: https://github.com/apache/airflow/pull/56371#discussion_r2414425023


##########
providers/amazon/tests/unit/amazon/aws/hooks/test_sqs.py:
##########
@@ -24,18 +24,95 @@
 
 from airflow.providers.amazon.aws.hooks.sqs import SqsHook
 
+QUEUE_NAME = "test-queue"
 QUEUE_URL = "https://sqs.region.amazonaws.com/123456789/test-queue";
 MESSAGE_BODY = "test message"
 
 MESSAGE_ID_KEY = "MessageId"
 
 
+@mock_aws
 class TestSqsHook:
-    @mock_aws
-    def test_get_conn(self):
+    @pytest.fixture(autouse=True)
+    def setup_test_queue(self):
+        """Create a test queue before each test"""
         hook = SqsHook(aws_conn_id="aws_default")
+        self.queue_url = 
hook.get_conn().create_queue(QueueName=QUEUE_NAME)["QueueUrl"]
+        yield
+
+    @pytest.fixture
+    def hook(self):
+        return SqsHook(aws_conn_id="aws_default")
+
+    def test_get_conn(self, hook):
         assert hook.get_conn() is not None
 
+    def test_create_queue(self, hook):
+        """Test that create_queue creates a queue and returns the queue URL"""

Review Comment:
   I made sure they all end in periods now, thank you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to