potiuk commented on issue #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#issuecomment-555999682 @ashb @kaxil @feluelle @coufon -> waiting for Travis CI now. Since I was modifying BaseOperator I also updated/fixed a few typehints to 3.6, fixed few - previously pylint-disabled - warnings, and also extracted (PyCharm noticed it) the object_to_json as common code between SerializedDAG and SerializedBaseOperator. Nice code! though I hope in the future we will keep the non-cyclic imports and won't have to do unnecessary pylint: disables for them (and the TYPE_CHECKING hack was particularly "interesting" ;). I will add a shortly the Executors separation (and enable Pylint in 'require serial' mode) which means that it will be always processing all files (not in pylint_todo.txt) in single process and in case of more cycles they should be detected immediately + add some more 'best-practices' checks in pre-commit to guide the developers in the future so that they will not introduce cycles accidentally.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
