bugraoz93 commented on code in PR #56124: URL: https://github.com/apache/airflow/pull/56124#discussion_r2443401372
########## airflow-ctl-tests/docker/docker-compose.yaml: ########## @@ -0,0 +1,106 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +--- +x-airflow-common: + &airflow-common + image: ${AIRFLOW_IMAGE_NAME:-apache/airflow:3.1.0} + environment: + &airflow-common-env + AIRFLOW__CORE__EXECUTOR: LocalExecutor + AIRFLOW__CORE__AUTH_MANAGER: airflow.providers.fab.auth_manager.fab_auth_manager.FabAuthManager + AIRFLOW__DATABASE__SQL_ALCHEMY_CONN: postgresql+psycopg2://airflow:airflow@postgres/airflow + AIRFLOW__CORE__FERNET_KEY: '' + AIRFLOW__CORE__LOAD_EXAMPLES: 'true' + AIRFLOW__API__EXPOSE_CONFIG: 'true' + user: "${AIRFLOW_UID:-50000}:0" + depends_on: + &airflow-common-depends-on + postgres: + condition: service_healthy + +services: + postgres: Review Comment: The compose file is now from core, we can maybe do some YAML manipulation on test runtime (compose interpretation time) and make it SQLite. Even though from envs we do SQLite, the compose service will still run if we don't delete from the compose file dynamically. It could make it error-prone to update and follow up on those updates. It would reduce the total time to run in total, though. I am not sure whether to convert it or not, still with the core compose What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
