kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348546748
########## File path: airflow/contrib/operators/dynamodb_to_s3.py ########## @@ -32,7 +32,7 @@ from boto.compat import json # type: ignore from airflow.contrib.hooks.aws_dynamodb_hook import AwsDynamoDBHook -from airflow.models.baseoperator import BaseOperator +from airflow.models import BaseOperator Review comment: I think we might be talking the same thing or maybe not :D What I was saying is `airflow.operators` and `airflow.contrib.operators` should use same kind of imports e.g "airflow.models.BaseOperator" "airflow.DAG" . ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
