potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove
cyclic imports and pylint disables
URL: https://github.com/apache/airflow/pull/6601#discussion_r348546793
##########
File path: airflow/models/baseoperator.py
##########
@@ -298,7 +294,7 @@ def __init__(
end_date: Optional[datetime] = None,
depends_on_past: bool = False,
wait_for_downstream: bool = False,
- dag: Optional[DAG] = None,
+ dag=None,
Review comment:
I think the problem here was that I wanted to avoid cyclic import here -
when you use 'DAG' in the __init__ parameters, the DAG has to be imported in
the class. I will see if I can still have it working with
"'airflow.models.dag.DAG'" maybe in quotes as forward-reference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services