potiuk commented on code in PR #56690:
URL: https://github.com/apache/airflow/pull/56690#discussion_r2446835912


##########
airflow-core/docs/administration-and-deployment/logging-monitoring/metrics.rst:
##########
@@ -254,6 +254,8 @@ Name                                                 
Description
 ``pool.scheduled_slots``                             Number of scheduled slots 
in the pool. Metric with pool_name tagging.
 ``pool.starving_tasks.<pool_name>``                  Number of starving tasks 
in the pool
 ``pool.starving_tasks``                              Number of starving tasks 
in the pool. Metric with pool_name tagging.
+``task.cpu_usage_percent.<dag_id>.<task_id>``        CPU usage percentage of a 
task

Review Comment:
   One other question - there is also a question of cardinality of course. 
Possibly reporting the stats on individual instances as gauge will produce a 
high cardinality statistics. Possibly the cardinality there is not "too high" 
if we do it per individual tis. But I am not sure. 
   
   When we are using gauge, only the last one counts, and previous values are 
replaced by the following ones - so effectively what we have is the valus in 
last execution of the "primary key". Not sure what is the best approach here. 
@HsiuChuanHsu -> any comments on that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to