ashb commented on code in PR #56589:
URL: https://github.com/apache/airflow/pull/56589#discussion_r2447508665
##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -126,358 +179,371 @@ spec:
labelSelector:
matchLabels:
component: worker
+ {{- if not $isDefaultWorker }}
+ worker-group: {{ $workerGroup.name }}
+ {{- end }}
topologyKey: kubernetes.io/hostname
weight: 100
{{- end }}
tolerations: {{- toYaml $tolerations | nindent 8 }}
topologySpreadConstraints: {{- toYaml $topologySpreadConstraints |
nindent 8 }}
- {{- if .Values.workers.hostAliases }}
- hostAliases: {{- toYaml .Values.workers.hostAliases | nindent 8 }}
+ {{- if $.Values.workers.hostAliases }}
+ hostAliases: {{- toYaml $.Values.workers.hostAliases | nindent 8 }}
{{- end }}
- terminationGracePeriodSeconds: {{
.Values.workers.terminationGracePeriodSeconds }}
+ terminationGracePeriodSeconds: {{
$.Values.workers.terminationGracePeriodSeconds }}
restartPolicy: Always
- {{- if .Values.workers.useWorkerDedicatedServiceAccounts }}
- serviceAccountName: {{ include "worker.celery.serviceAccountName" . }}
+ {{- if $.Values.workers.useWorkerDedicatedServiceAccounts }}
+ serviceAccountName: {{ include "worker.celery.serviceAccountName" $ }}
{{- else }}
- serviceAccountName: {{ include "worker.serviceAccountName" . }}
+ serviceAccountName: {{ include "worker.serviceAccountName" $ }}
{{- end }}
securityContext: {{ $securityContext | nindent 8 }}
- {{- if or .Values.registry.secretName .Values.registry.connection }}
+ {{- if or $.Values.registry.secretName $.Values.registry.connection }}
Review Comment:
Do we need to change all these from `.Values` to `$.Values`? Since we have
`{{- range $groupIndex, $workerGroup := $workerGroups }}` at the top, the `.` I
thought was left un-altered.
(If changing this is _required_, that's fine, but otherwise this change
makes the diff much much harder to review)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
