uranusjr commented on code in PR #56929:
URL: https://github.com/apache/airflow/pull/56929#discussion_r2447555618
##########
providers/amazon/tests/unit/amazon/aws/executors/ecs/test_ecs_executor.py:
##########
@@ -1344,9 +1343,8 @@ def test_subnets_required(self):
(CONFIG_GROUP_NAME, AllEcsConfigKeys.SECURITY_GROUPS): "sg1,sg2",
}
with conf_vars(conf_overrides):
- with pytest.raises(ValueError) as raised:
+ with pytest.raises(ValueError, match="At least one subnet is
required to run a task."):
Review Comment:
(Rant) I never liked the `match` argument because it somewhat unintuitively
takes a regular expression, and the final dot here is actually a wildcard
instead a literal period. I hate the PT011 rule by extension because it
promotes the usage without appropriate explaination and people end up using the
argument incorrectly.
I’ve never cared _enough_ to ask pytest to add a `literal_match` argument
though, so I guess that’s on myself. Anyway, this would not really break the
test either way, so I guess it is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
