hwang-cadent opened a new pull request, #56973:
URL: https://github.com/apache/airflow/pull/56973
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Fixes #46402 - Dynamic dag_id resolution in TriggerDagRunOperator links
## Description
This PR addresses the issue where `TriggerDagRunOperator` links fail to work
correctly when the `dag_id` is dynamically determined at runtime (e.g., from
XCom values or complex templates). The current implementation only uses the
static `trigger_dag_id` attribute, which doesn't reflect the actual resolved
dag_id when it's determined dynamically.
## Changes
- Added `XCOM_DAG_ID` constant to store the resolved dag_id in XCom during
task execution
- Modified `TriggerDagRunLink.get_link()` to prioritize XCom values over
static operator attributes
- Updated both Airflow 2.x (`_trigger_dag_af_2`) and 3.x
(`_trigger_dag_af_3`) execution paths to push the resolved dag_id to XCom
- Added comprehensive test coverage for dynamic dag_id scenarios in both
Airflow versions
- Maintained full backward compatibility with existing static dag_id usage
- Added proper error handling for test environments where supervisor
communication isn't available
## Testing
- All existing tests continue to pass (10 tests passed, 26 skipped for
Airflow 2.x compatibility)
- Added new test cases for dynamic dag_id resolution in both Airflow 2.x and
3.x
- Verified backward compatibility with static dag_id usage
- Tested error handling for environments without supervisor communication
- Ensured XCom fallback behavior works correctly
## Type of Change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
