Pei-Cheng-Yu commented on code in PR #56920: URL: https://github.com/apache/airflow/pull/56920#discussion_r2450513930
########## airflow-core/src/airflow/ui/src/pages/TaskInstances/StateFilter.tsx: ########## @@ -0,0 +1,88 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { HStack, type SelectValueChangeDetails } from "@chakra-ui/react"; + +import type { TaskInstanceState } from "openapi/requests/types.gen"; +import { StateBadge } from "src/components/StateBadge"; +import { Select } from "src/components/ui"; +import { taskInstanceStateOptions } from "src/constants/stateOptions"; + +type Props<V extends string> = { + readonly maxW?: string; + readonly onChange: (details: SelectValueChangeDetails<V>) => void; + readonly translate: (key: string) => string; + readonly value: Array<V>; // e.g. (TaskInstanceState | "all" | "none")[] +}; + +export const StateFilter = <V extends string>({ maxW = "450px", onChange, translate, value }: Props<V>) => { Review Comment: I agree with making a filter config and implementing it with the FilterBar. I initially thought we should keep the state filter with the multi-select function, but I can't find a way to integrate it with the FilterBar while keeping that feature. The separate component was created because I got a “file too long” error when testing with prek locally. I’ll make sure to check the requirements next time before starting changes. Thanks for the review! I’ll fix it and upload the update in a few days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
