amoghrajesh commented on code in PR #56493:
URL: https://github.com/apache/airflow/pull/56493#discussion_r2450520945
##########
chart/templates/api-server/api-server-ingress.yaml:
##########
@@ -20,7 +20,7 @@
################################
## Airflow API Server Ingress
#################################
-{{- if semverCompare ">=3.0.0" .Values.airflowVersion }}
+{{- if and .Values.apiServer.enabled (semverCompare ">=3.0.0"
.Values.airflowVersion) }}
Review Comment:
nit: flip the check
##########
chart/templates/api-server/api-server-networkpolicy.yaml:
##########
@@ -20,7 +20,7 @@
################################
## Airflow API Server NetworkPolicy
#################################
-{{- if semverCompare ">=3.0.0" .Values.airflowVersion }}
+{{- if and .Values.apiServer.enabled (semverCompare ">=3.0.0"
.Values.airflowVersion) }}
Review Comment:
nit: flip the check
##########
chart/templates/api-server/api-server-deployment.yaml:
##########
@@ -20,7 +20,7 @@
################################
## Airflow API Server Deployment
#################################
-{{- if semverCompare ">=3.0.0" .Values.airflowVersion }}
+{{- if and .Values.apiServer.enabled (semverCompare ">=3.0.0"
.Values.airflowVersion) }}
Review Comment:
nit: flip the check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
