o-nikolas commented on PR #56936: URL: https://github.com/apache/airflow/pull/56936#issuecomment-3434480919
> > Thanks for the contribution! Overall it looks quite good. Some feedback: > > I don't love the mixture of changes. It's better to make your PRs as tightly scoped as possible, if you spot other things to fix try to do them in a separate PR. > > You have some tests failing that need looking into, static checks can be run on your development machine (automatically as well as pre-commit/pre-push hooks), see the docs [here](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst) for how to run those. > > Thank you for the kind words. Re: Mixture of changes: I understand, and I'll make sure all changes are in their own PR going forward. Please let me know if you want me to revert this commit, and move to a new PR, or I'll be granted exception this time. Thank you! It's all good this time, no need to move to a new PR. You still have some static checks failing though. Ruff would be automatically fixed for you on pre-commit/pre-push if you enable those :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
