This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new e155012353b Migrate pinecone provider to `common.compat` (#57137)
e155012353b is described below
commit e155012353b0ca3bfb55de2e4add596674170f37
Author: rich7420 <[email protected]>
AuthorDate: Fri Oct 24 00:52:09 2025 +0800
Migrate pinecone provider to `common.compat` (#57137)
* Migrate remaining providers to common.compat compatibility layer
* Apply suggestion from @kaxil
---------
Co-authored-by: Kaxil Naik <[email protected]>
---
providers/pinecone/pyproject.toml | 2 ++
.../src/airflow/providers/pinecone/hooks/pinecone.py | 2 +-
.../src/airflow/providers/pinecone/operators/pinecone.py | 2 +-
.../src/airflow/providers/pinecone/version_compat.py | 13 +------------
4 files changed, 5 insertions(+), 14 deletions(-)
diff --git a/providers/pinecone/pyproject.toml
b/providers/pinecone/pyproject.toml
index 049726df101..93c114d9b77 100644
--- a/providers/pinecone/pyproject.toml
+++ b/providers/pinecone/pyproject.toml
@@ -58,6 +58,7 @@ requires-python = ">=3.10"
# After you modify the dependencies, and rebuild your Breeze CI image with
``breeze ci-image build``
dependencies = [
"apache-airflow>=2.10.0",
+ "apache-airflow-providers-common-compat>=1.8.0",
"pinecone>=7.0.0",
]
@@ -66,6 +67,7 @@ dev = [
"apache-airflow",
"apache-airflow-task-sdk",
"apache-airflow-devel-common",
+ "apache-airflow-providers-common-compat",
# Additional devel dependencies (do not remove this line and add extra
development dependencies)
]
diff --git
a/providers/pinecone/src/airflow/providers/pinecone/hooks/pinecone.py
b/providers/pinecone/src/airflow/providers/pinecone/hooks/pinecone.py
index 07b16d84841..73a43f82770 100644
--- a/providers/pinecone/src/airflow/providers/pinecone/hooks/pinecone.py
+++ b/providers/pinecone/src/airflow/providers/pinecone/hooks/pinecone.py
@@ -26,7 +26,7 @@ from typing import TYPE_CHECKING, Any
from pinecone import Pinecone, PodSpec, PodType, ServerlessSpec
-from airflow.providers.pinecone.version_compat import BaseHook
+from airflow.providers.common.compat.sdk import BaseHook
if TYPE_CHECKING:
from pinecone import Vector
diff --git
a/providers/pinecone/src/airflow/providers/pinecone/operators/pinecone.py
b/providers/pinecone/src/airflow/providers/pinecone/operators/pinecone.py
index 9d2059c6b63..bdabe442523 100644
--- a/providers/pinecone/src/airflow/providers/pinecone/operators/pinecone.py
+++ b/providers/pinecone/src/airflow/providers/pinecone/operators/pinecone.py
@@ -21,8 +21,8 @@ from collections.abc import Sequence
from functools import cached_property
from typing import TYPE_CHECKING, Any
+from airflow.providers.common.compat.sdk import BaseOperator
from airflow.providers.pinecone.hooks.pinecone import PineconeHook
-from airflow.providers.pinecone.version_compat import BaseOperator
if TYPE_CHECKING:
from pinecone import Vector
diff --git
a/providers/pinecone/src/airflow/providers/pinecone/version_compat.py
b/providers/pinecone/src/airflow/providers/pinecone/version_compat.py
index ad7b31ea701..fe3ccfcfd3d 100644
--- a/providers/pinecone/src/airflow/providers/pinecone/version_compat.py
+++ b/providers/pinecone/src/airflow/providers/pinecone/version_compat.py
@@ -30,18 +30,7 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:
AIRFLOW_V_3_0_PLUS = get_base_airflow_version_tuple() >= (3, 0, 0)
AIRFLOW_V_3_1_PLUS: bool = get_base_airflow_version_tuple() >= (3, 1, 0)
-if AIRFLOW_V_3_1_PLUS:
- from airflow.sdk import BaseHook
-else:
- from airflow.hooks.base import BaseHook # type:
ignore[attr-defined,no-redef]
-
-if AIRFLOW_V_3_0_PLUS:
- from airflow.sdk import BaseOperator
-else:
- from airflow.models import BaseOperator
-
__all__ = [
"AIRFLOW_V_3_0_PLUS",
- "BaseHook",
- "BaseOperator",
+ "AIRFLOW_V_3_1_PLUS",
]
