o-nikolas commented on PR #57098: URL: https://github.com/apache/airflow/pull/57098#issuecomment-3438341206
> Having trouble running the failing CI test `providers/amazon/tests/unit/amazon/aws/hooks/test_athena_sql.py::TestAthenaSQLHookConn::test_get_uri` (which is failing locally due to db reasons, I suspect this has to do with this change from 2 days ago: [e8194f1](https://github.com/apache/airflow/commit/e8194f12e8ea339ba8c9edc284467db57e516972)) > > but I think to get the CI test to work, the issue is just that since you typecast to string explicitly higher upstream, the `render_as_string` method throws an error. Maybe `render_as_string` should be written to handle string inputs by doing nothing instead? This was a Draft PR just to get tests running, no need to review @seanghaeli :) And yes that test was failing because it used to return a `URL` object that had a `render_as_string()` method, but a string is now returned directly. I have some changes in a branch already that I'll push up soon! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
