amoghrajesh commented on code in PR #57172:
URL: https://github.com/apache/airflow/pull/57172#discussion_r2456663072
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -1129,15 +1129,15 @@ def _send_heartbeat_if_needed(self):
except Exception as e:
self._handle_heartbeat_failures(e)
- def _handle_heartbeat_failures(self, exc: Exception | None):
Review Comment:
This is called explicitly above in two places by passing a valid `e`:
`self._handle_heartbeat_failures(e)` and hence `e` cannot be None. Removed that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
