amoghrajesh opened a new pull request, #57198:
URL: https://github.com/apache/airflow/pull/57198
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Next part to: https://github.com/apache/airflow/pull/57056
Expanding the tests to cover more breadth in the task instance space itself.
The tests now added cover these:
1. `test_ti_set_rtif`
- Sets Rendered Task Instance Fields
- Tests the endpoint: `PUT /task-instances/{id}/rtif`
2. `test_ti_heartbeat`
- Sends heartbeat for a running task instance
- Tests the endpoint: `PUT /task-instances/{id}/heartbeat`
- **Special Implementation**: Fetches actual worker PID/hostname from
Core API, then patches `get_hostname()` to match, ensuring heartbeat validation
succeeds
- Validates PID/hostname matching logic
3. 7`test_ti_state_transitions`
- Tests state transition to terminal state (FAILED)
- Tests the endpoint: `PATCH /task-instances/{id}/state`
- Validates the `finish()` method
- Will expand this further to cover deferred as well as up_for_retry
## What's Next
Following the testing roadmap, the next priorities are:
1. XCom operations tests
2. Variable operations tests
3. Connection operations tests
4. DAG Run operations tests
5. Asset operations tests
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
