chiuinggum commented on code in PR #57199: URL: https://github.com/apache/airflow/pull/57199#discussion_r2462407726
########## providers/fab/src/airflow/providers/fab/auth_manager/api_fastapi/services/roles.py: ########## @@ -0,0 +1,80 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import TYPE_CHECKING, cast + +from starlette import status +from starlette.exceptions import HTTPException + +from airflow.api_fastapi.app import get_auth_manager +from airflow.providers.fab.auth_manager.api_fastapi.datamodels.roles import RoleIn, RoleOut + +if TYPE_CHECKING: + from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager + from airflow.providers.fab.auth_manager.security_manager.override import FabAirflowSecurityManagerOverride + + +class FABAuthManagerRoles: + """Service layer for FAB Auth Manager role operations (create, validate, sync).""" + + @staticmethod + def _check_action_and_resource( + sm: FabAirflowSecurityManagerOverride, + perms: list[tuple[str, str]], + ) -> None: + for action_name, resource_name in perms: + if not sm.get_action(action_name): + raise HTTPException( + status_code=status.HTTP_400_BAD_REQUEST, + detail=f"The specified action: {action_name!r} was not found", + ) + if not sm.get_resource(resource_name): + raise HTTPException( + status_code=status.HTTP_400_BAD_REQUEST, + detail=f"The specified resource: {resource_name!r} was not found", + ) + + @classmethod + def create_role(cls, body: RoleIn) -> RoleOut: + if not body or not body.name: + raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail="Role name must be provided") Review Comment: @vincbeck [Legacy behavior](https://github.com/apache/airflow/blob/main/providers/fab/src/airflow/providers/fab/auth_manager/api_endpoints/role_and_permission_endpoint.py#L161-L166) returned `400 Bad Request` for invalid/empty bodies. Since we can let Pydantic handle this automatically, I’m switching to Pydantic validation so empty strings are rejected with `422 Unprocessable Entity`. Concretely: ```diff class RoleBody(StrictBaseModel): - name: str + name: str = Field(min_length=1) ``` This means a request with `name=""` will fail validation and FastAPI will return 422: ```json { "detail": [ { "type": "string_too_short", "loc": [ "body", "name" ], "msg": "String should have at least 1 character", "input": "", "ctx": { "min_length": 1 } } ] } ``` I proceed with 422 in the latest commit. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
