KoviAnusha commented on code in PR #57221:
URL: https://github.com/apache/airflow/pull/57221#discussion_r2462599179
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dags.py:
##########
@@ -162,10 +162,11 @@ def get_dags(
session=session,
)
- dags = session.scalars(dags_select)
+ dags_list = list(session.scalars(dags_select))
Review Comment:
Nice cleanup, the list() cast and explicit type annotation really help mypy
here.
You may consider renaming dags_list → dags_raw or raw_dags later to make the
intent even clearer. Not blocking, though this change is solid and improves
type safety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
