jscheffl commented on code in PR #56875:
URL: https://github.com/apache/airflow/pull/56875#discussion_r2464127459
##########
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/triggers/test_pod.py:
##########
@@ -63,11 +64,25 @@ def trigger():
in_cluster=IN_CLUSTER,
get_logs=GET_LOGS,
startup_timeout=STARTUP_TIMEOUT_SECS,
+ startup_check_interval=STARTUP_CHECK_INTERVAL_SECS,
+ schedule_timeout=STARTUP_TIMEOUT_SECS,
trigger_start_time=TRIGGER_START_TIME,
on_finish_action=ON_FINISH_ACTION,
)
[email protected]
+def mock_time_fixture():
Review Comment:
Tests fail on too many calls of the fixture. I assume you need to fill a new
more data points to fixture for a support of some old versions:
```
---
a/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/triggers/test_pod.py
+++
b/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/triggers/test_pod.py
@@ -77,8 +77,7 @@ def mock_time_fixture():
with mock.patch("time.time") as mock_time:
start_time = 1000
mock_time.side_effect = [
- start_time,
- start_time + STARTUP_TIMEOUT_SECS,
+ *(start_time + STARTUP_TIMEOUT_SECS * n for n in range(5)),
]
yield mock_time
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
