bhavaniravi commented on code in PR #57320:
URL: https://github.com/apache/airflow/pull/57320#discussion_r2464200788
##########
airflow-core/src/airflow/dag_processing/dagbag.py:
##########
@@ -618,12 +618,12 @@ def collect_dags(
files_to_parse = list_py_file_paths(dag_folder, safe_mode=safe_mode)
- if include_examples:
- from airflow import example_dags
+ # if include_examples:
Review Comment:
This change felt bold. Which is why I commented it out. If we were to let
DagBag load examples, then we are duplicating the provider examples loading in
both Dagbundle and in dagbag.
Will this affect backward compatibility?
##########
devel-common/src/tests_common/test_utils/db.py:
##########
Review Comment:
Something that threw me off,
`DagBundlesManager().sync_bundles_to_db(session=session)`, I assumed it would
create the Dag objects in the DB, but it didn't, hence the snippet below
Was it a conscious choice to keep the DAG parsing and DB entries creation to
dagbag alone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
