MaksYermak commented on code in PR #56324:
URL: https://github.com/apache/airflow/pull/56324#discussion_r2464904633
##########
providers/google/docs/index.rst:
##########
Review Comment:
@Ankurdeewan all this new added text shouldn't be in this file, because this
file contains only information about `google-provider` which displays in pypi.
Could you please move this information at the end of `gcp.rst` I think it will
be a good place for this information because as I see it is related to Google
Cloud Platform connection?
##########
providers/google/docs/connections/gcp.rst:
##########
@@ -117,7 +117,16 @@ Secret name which holds Keyfile JSON
Not required if using application default credentials.
Scopes (comma separated)
- A list of comma-separated `Google Cloud scopes
+ A list of comma-separated `Google Cloud scopes
+
+Quota Project ID (optional)
+ The Google Cloud project ID to use for API quota and billing purposes. This
is useful when using a shared service account but want to attribute
quota/billing to a different project. If not specified, the default project
from the connection is used. Must be a valid GCP project ID (lowercase letters,
digits, hyphens, 6-30 characters, starting with a letter).
+
+ .. note::
+ If using anonymous credentials, quota project logic is ignored.
+
+ .. warning::
+ Ensure the service account has permission to use the specified quota
project. Invalid or unauthorized quota project IDs will result in an error.
Review Comment:
@Ankurdeewan I have noticed that this new added part of the documentation
breaks the `Scopes` paragraph which looks like this:
```
Scopes (comma separated)
A list of comma-separated `Google Cloud scopes
<https://developers.google.com/identity/protocols/googlescopes>`_ to
authenticate with.
```
Could you please fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
