This is an automated email from the ASF dual-hosted git repository.
vincbeck pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 753bd1903c6 Fix MyPy type errors in /api_fastapi/core_api/
connections.py,pools.py,variables.py for Sqlalchemy 2 migration (#57272)
753bd1903c6 is described below
commit 753bd1903c60eaa709e80cd7839f6ab0f7ee50a1
Author: Anusha Kovi <[email protected]>
AuthorDate: Mon Oct 27 18:59:23 2025 +0530
Fix MyPy type errors in /api_fastapi/core_api/
connections.py,pools.py,variables.py for Sqlalchemy 2 migration (#57272)
---
.../api_fastapi/core_api/services/public/connections.py | 2 +-
.../airflow/api_fastapi/core_api/services/public/pools.py | 15 ++++++++++-----
.../api_fastapi/core_api/services/public/variables.py | 15 ++++++++++-----
3 files changed, 21 insertions(+), 11 deletions(-)
diff --git
a/airflow-core/src/airflow/api_fastapi/core_api/services/public/connections.py
b/airflow-core/src/airflow/api_fastapi/core_api/services/public/connections.py
index 7cf70935118..2acf23528ad 100644
---
a/airflow-core/src/airflow/api_fastapi/core_api/services/public/connections.py
+++
b/airflow-core/src/airflow/api_fastapi/core_api/services/public/connections.py
@@ -152,7 +152,7 @@ class BulkConnectionService(BulkService[ConnectionBody]):
for connection in action.entities:
if connection.connection_id in update_connection_ids:
- old_connection: Connection = self.session.scalar(
+ old_connection = self.session.scalar(
select(Connection).filter(Connection.conn_id ==
connection.connection_id).limit(1)
)
if old_connection is None:
diff --git
a/airflow-core/src/airflow/api_fastapi/core_api/services/public/pools.py
b/airflow-core/src/airflow/api_fastapi/core_api/services/public/pools.py
index cc2d6696b5c..1edadb97cc6 100644
--- a/airflow-core/src/airflow/api_fastapi/core_api/services/public/pools.py
+++ b/airflow-core/src/airflow/api_fastapi/core_api/services/public/pools.py
@@ -17,6 +17,8 @@
from __future__ import annotations
+from typing import cast
+
from fastapi import HTTPException, status
from fastapi.exceptions import RequestValidationError
from pydantic import ValidationError
@@ -97,11 +99,14 @@ def update_orm_from_pydantic(
raise RequestValidationError(errors=e.errors())
# Delegate patch application to the common utility
- return BulkService.apply_patch_with_update_mask(
- model=pool,
- patch_body=patch_body,
- update_mask=update_mask,
- non_update_fields=None,
+ return cast(
+ "Pool",
+ BulkService.apply_patch_with_update_mask(
+ model=pool,
+ patch_body=patch_body,
+ update_mask=update_mask,
+ non_update_fields=None,
+ ),
)
diff --git
a/airflow-core/src/airflow/api_fastapi/core_api/services/public/variables.py
b/airflow-core/src/airflow/api_fastapi/core_api/services/public/variables.py
index 4c049ca6e78..6296f22828f 100644
--- a/airflow-core/src/airflow/api_fastapi/core_api/services/public/variables.py
+++ b/airflow-core/src/airflow/api_fastapi/core_api/services/public/variables.py
@@ -17,6 +17,8 @@
from __future__ import annotations
+from typing import cast
+
from fastapi import HTTPException, status
from fastapi.exceptions import RequestValidationError
from pydantic import ValidationError
@@ -76,11 +78,14 @@ def update_orm_from_pydantic(
)
# Apply patch via utility
- return BulkService.apply_patch_with_update_mask(
- model=old_variable,
- patch_body=patch_body,
- update_mask=update_mask,
- non_update_fields=non_update_fields,
+ return cast(
+ "Variable",
+ BulkService.apply_patch_with_update_mask(
+ model=old_variable,
+ patch_body=patch_body,
+ update_mask=update_mask,
+ non_update_fields=non_update_fields,
+ ),
)
