jscheffl commented on PR #57370: URL: https://github.com/apache/airflow/pull/57370#issuecomment-3453368352
> > > > > Should you set a constraint on Airflow >= 3.1.1 or you intend to doit in a follow-up PR? > > > > > > > > > > > > Constraint is already on main in https://github.com/boschglobal/airflow/blob/main/providers/edge3/pyproject.toml#L60 - so no additional imitation needed here. Note: I actually _thought_ earlier that the change of the dom-router was a breaking change but needed to realize that the token was breaking "harder". > > > > > > > > > I think it should be set to >= 3.1.1, I do not think this would work, for example, with 3.0.0 > > > > > > Oh okay. yeah actually it is: > > > > * It is working with Airflow 2.10+2.11 as there is a "legacy UI" plugin used. > > * It is not a problem in 3.0.x as this Airflow version is lagging any Plugin function. > > * The breaking change is only between 3.1.0 and 3.1.1++ > > > > The general Edge Worker/Executor is not affected from the breaking change, _only_ the UI plugin has a problem with exactly and only 3.1.0. And this is only acceptable as the UI plugin functionality is marked experimental in 3.1.0 that allows us to fix problems in React integration (which sadly we need to :-( ) > > Ohhh you're right! My god, this is a puzzle between all the versions haha. But it is fine by me then :) I hope all this hairball is resolved soon so that I can drain this complexity from my brain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
