potiuk commented on code in PR #56881: URL: https://github.com/apache/airflow/pull/56881#discussion_r2467386045
########## airflow-core/newsfragments/56881.significant.rst: ########## @@ -0,0 +1,38 @@ +.. Write a short and imperative summary of this changes + +Custom SerDe methods defined on classes now take precedence over the built-in SerDe methods. + +.. Provide additional contextual information +Previously, the SerDe precedence prioritized built-in serializers in airflow-core over those that users defined +in their classes with the ``serialize(self)`` and ``deserialize(data: dict, version: int)`` methods. +This behavior has been changed to always use custom SerDe methods before considering built-in SerDe methods. + +.. Check the type of change that applies to this change Review Comment: You can remove those comments. ########## airflow-core/newsfragments/56881.significant.rst: ########## @@ -0,0 +1,38 @@ +.. Write a short and imperative summary of this changes + +Custom SerDe methods defined on classes now take precedence over the built-in SerDe methods. + +.. Provide additional contextual information +Previously, the SerDe precedence prioritized built-in serializers in airflow-core over those that users defined +in their classes with the ``serialize(self)`` and ``deserialize(data: dict, version: int)`` methods. +This behavior has been changed to always use custom SerDe methods before considering built-in SerDe methods. + +.. Check the type of change that applies to this change +.. Dag changes: requires users to change their Dag code +.. Config changes: requires users to change their Airflow config +.. API changes: requires users to change their Airflow REST API calls +.. CLI changes: requires users to change their Airflow CLI usage +.. Behaviour changes: the existing code won't break, but the behavior is different +.. Plugin changes: requires users to change their Airflow plugin implementation +.. Dependency changes: requires users to change their dependencies (e.g., Postgres 12) +.. Code interface changes: requires users to change other implementations (e.g., auth manager) + +* Types of change + + * [ ] Dag changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [x] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency changes + * [ ] Code interface changes + +.. List the migration rules needed for this change (see https://github.com/apache/airflow/issues/41641) Review Comment: Same here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
