ramitkataria commented on code in PR #57215:
URL: https://github.com/apache/airflow/pull/57215#discussion_r2467524125
##########
task-sdk/src/airflow/sdk/definitions/deadline.py:
##########
@@ -121,13 +121,13 @@ class Callback(ABC):
"""
path: str
- kwargs: dict | None
+ kwargs: dict
Review Comment:
kwargs is still an optional parameter in the constructor. I've just changed
the internal representation so that null kwargs are stored as an empty dict.
This helps with reducing `if` statements and edge cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
