kaxil commented on code in PR #57397:
URL: https://github.com/apache/airflow/pull/57397#discussion_r2467601570
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -2507,6 +2507,23 @@ def serialize_dag(cls, dag: DAG) -> dict:
serialized_dag["has_on_success_callback"] = True
if dag.has_on_failure_callback:
serialized_dag["has_on_failure_callback"] = True
+
+ # TODO: Move this logic to a better place -- ideally before
serializing contents of default_args.
+ # There is some duplication with this and
SerializedBaseOperator.partial_kwargs serialization.
+ # Ideally default_args goes through same logic as fields of
SerializedBaseOperator.
Review Comment:
Added todo -- since we can reduce some duplication of this logic at multiple
places -- but I do want to get it in 3.1.2 so this should work for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
