amoghrajesh commented on code in PR #57352:
URL: https://github.com/apache/airflow/pull/57352#discussion_r2468735667


##########
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/asset.py:
##########
@@ -26,7 +28,7 @@ class AssetResponse(BaseModel):
     name: str
     uri: str
     group: str
-    extra: dict | None = None
+    extra: dict[str, JsonValue] | None = None

Review Comment:
   On the runtime side, the runtime json remains the same, so I do not think we 
need a cadywn migration here



##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/assets.py:
##########
@@ -19,7 +19,14 @@
 
 from datetime import datetime
 
-from pydantic import AliasPath, ConfigDict, Field, NonNegativeInt, 
field_validator
+from pydantic import (
+    AliasPath,
+    ConfigDict,
+    Field,
+    JsonValue,
+    NonNegativeInt,
+    field_validator,
+)

Review Comment:
   Can we undo formatting changes here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to