bbovenzi commented on code in PR #56347:
URL: https://github.com/apache/airflow/pull/56347#discussion_r2470057805
##########
airflow-core/src/airflow/ui/src/pages/Variables/ImportVariablesForm.tsx:
##########
@@ -154,7 +154,7 @@ const ImportVariablesForm = ({ onClose }:
ImportVariablesFormProps) => {
</InputGroup>
{isParsing ? (
<Center mt={2}>
- <Spinner color="brand.solid" marginRight={2} size="sm" /> Parsing
file...
+ <Spinner color="import-variables.spinner.color" marginRight={2}
size="sm" /> Parsing file...
Review Comment:
This feels oddly specific. I feel like `brand.solid` was perfectly fine as a
semantic token?
##########
airflow-core/src/airflow/ui/src/theme.ts:
##########
@@ -392,35 +398,205 @@ export const customConfig = defineConfig({
zinc: generateSemanticTokens("zinc"),
neutral: generateSemanticTokens("neutral"),
stone: generateSemanticTokens("stone"),
+
+ // COMPONENT-SPECIFIC SEMANTIC TOKENS
+
+ // components/DataTable/
+ "data-table": {
+ header: {
+ bg: { value: { _light: "{colors.gray.50}", _dark:
"{colors.gray.800}" } },
+ text: { value: { _light: "{colors.gray.700}", _dark:
"{colors.gray.300}" } },
+ border: { value: { _light: "{colors.gray.200}", _dark:
"{colors.gray.700}" } }
+ },
+ row: {
+ bg: {
+ default: { value: { _light: "white", _dark: "{colors.gray.900}"
} },
+ hover: { value: { _light: "{colors.gray.50}", _dark:
"{colors.gray.800}" } }
+ },
+ border: { value: { _light: "{colors.gray.100}", _dark:
"{colors.gray.800}" } }
+ },
+ cell: {
+ text: { value: { _light: "{colors.gray.700}", _dark:
"{colors.gray.300}" } },
+ muted: { value: { _light: "{colors.gray.500}", _dark:
"{colors.gray.500}" } }
+ },
+ },
+
+ // components/EditableMarkdownButton.tsx
+ "editable-markdown-button": {
+ indicator: {
+ bg: { value: "{colors.brand.500}" }
+ },
+ header: {
+ bg: { value: { _light: "{colors.brand.200}", _dark:
"{colors.brand.800}" } }
+ }
+ },
+
+ // components/FilterBar/
+ "filter-bar": {
+ pill: {
+ close: {
+ color: { value: { _light: "{colors.gray.400}", _dark:
"{colors.gray.400}" } },
+ bg: {
+ hover: { value: { _light: "{colors.gray.100}", _dark:
"{colors.gray.700}" } }
+ }
+ }
+ }
+ },
+ // components/TrendCountChart.tsx
+ "trend-count-chart": {
+ success: {
+ bg: { value: { _light: "{colors.green.100}", _dark:
"{colors.green.800}" } },
+ line: { value: { _light: "{colors.green.500}", _dark:
"{colors.green.400}" } }
+ },
+ failed: {
+ bg: { value: { _light: "{colors.red.100}", _dark:
"{colors.red.800}" } },
+ line: { value: { _light: "{colors.red.500}", _dark:
"{colors.red.400}" } }
+ }
+ },
+ // components/ui/Toaster/Toaster.tsx
+ toaster: {
+ spinner: {
+ color: { value: "{colors.brand.600}" }
+ }
+ },
+ // layouts/Details/Gantt/Gantt.tsx
+ gantt: {
+ grid: {
+ color: { value: { _light: "{colors.gray.200}", _dark:
"{colors.gray.800}" } }
+ },
+ bg: {
+ selected: { value: { _light: "{colors.gray.100}", _dark:
"{colors.gray.700}" } },
+ hover: { value: { _light: "{colors.gray.50}", _dark:
"{colors.gray.800}" } }
+ }
+ },
+
+ // layouts/Details/Graph/Graph.tsx
+ graph: {
+ node: {
+ success: { value: "{colors.green.500}" },
+ failed: { value: "{colors.red.500}" },
+ running: { value: "{colors.cyan.500}" },
+ queued: { value: "{colors.yellow.500}" },
+ skipped: { value: "{colors.gray.400}" },
Review Comment:
I think skipped is supposed to be pink, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
