KoviAnusha commented on code in PR #57408:
URL: https://github.com/apache/airflow/pull/57408#discussion_r2470102641
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -186,7 +186,7 @@ def search_param_factory(
attribute: ColumnElement,
pattern_name: str,
skip_none: bool = True,
-) -> Callable[[str | None], _SearchParam]:
+) -> Callable[..., _SearchParam]:
Review Comment:
I removed them to make the callable more generic. The function can take
different kinds of params, not just str or None, so using Callable[...,
_SearchParam] avoids type issues and matches how it’s actually used. Should we
not do like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
