guan404ming commented on code in PR #56760:
URL: https://github.com/apache/airflow/pull/56760#discussion_r2470236854
##########
airflow-core/src/airflow/ui/src/utils/hitl.ts:
##########
@@ -18,22 +18,22 @@
*/
import type { TFunction } from "i18next";
-import type { HITLDetail } from "openapi/requests/types.gen";
+import type { HITLDetail, HITLDetailHisotry } from
"openapi/requests/types.gen";
Review Comment:
```suggestion
import type { HITLDetail, HITLDetailHistory } from
"openapi/requests/types.gen";
```
typo
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/HITLResponse.tsx:
##########
@@ -18,26 +18,73 @@
*/
import { Box } from "@chakra-ui/react";
import { useParams } from "react-router-dom";
+import { useSearchParams } from "react-router-dom";
-import { useTaskInstanceServiceGetHitlDetail } from "openapi/queries";
+import {
+ useTaskInstanceServiceGetHitlDetailTry,
+ useTaskInstanceServiceGetMappedTaskInstance,
+} from "openapi/queries";
+import { TaskTrySelect } from "src/components/TaskTrySelect";
import { ProgressBar } from "src/components/ui";
+import { SearchParamsKeys } from "src/constants/searchParams";
+import { isStatePending, useAutoRefresh } from "src/utils";
import { HITLResponseForm } from "../HITLTaskInstances/HITLResponseForm";
export const HITLResponse = () => {
const { dagId, mapIndex, runId, taskId } = useParams();
- const { data: hitlDetail } = useTaskInstanceServiceGetHitlDetail(
+ const refetchInterval = useAutoRefresh({ dagId });
+ const [searchParams, setSearchParams] = useSearchParams();
+ const tryNumberParam = searchParams.get(SearchParamsKeys.TRY_NUMBER);
+
+ const parsedMapIndex = Number(mapIndex ?? -1);
+
+ const { data: taskInstance } = useTaskInstanceServiceGetMappedTaskInstance(
{
dagId: dagId ?? "",
dagRunId: runId ?? "",
- mapIndex: Number(mapIndex ?? -1),
+ mapIndex: parsedMapIndex,
taskId: taskId ?? "",
},
undefined,
+ {
+ enabled: !isNaN(parsedMapIndex),
+ refetchInterval: (query) => (isStatePending(query.state.data?.state) ?
refetchInterval : false),
+ },
);
- if (!hitlDetail?.task_instance) {
+ const onSelectTryNumber = (newTryNumber: number) => {
+ if (newTryNumber === taskInstance?.try_number) {
+ searchParams.delete(SearchParamsKeys.TRY_NUMBER);
+ } else {
+ searchParams.set(SearchParamsKeys.TRY_NUMBER, newTryNumber.toString());
+ }
+ setSearchParams(searchParams);
+ };
+
+ const tryNumber = tryNumberParam === null ? -1 : parseInt(tryNumberParam,
10);
+
+ const { data: hitlDetail } = useTaskInstanceServiceGetHitlDetailTry(
+ {
+ dagId: dagId ?? "",
+ dagRunId: runId ?? "",
+ mapIndex: parsedMapIndex,
+ taskId: taskId ?? "",
+ tryNumber,
+ },
+ undefined,
+ );
+
+ if (!taskInstance) {
Review Comment:
```suggestion
if (!taskInstance || !hitlDetail) {
```
nit one, then we could remove the below one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
