KoviAnusha commented on code in PR #57452:
URL: https://github.com/apache/airflow/pull/57452#discussion_r2470850077
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/backfills.py:
##########
@@ -162,6 +162,7 @@ def unpause_backfill(backfill_id: NonNegativeInt, session:
SessionDep) -> Backfi
raise HTTPException(status.HTTP_409_CONFLICT, "Backfill is already
completed.")
if b.is_paused:
b.is_paused = False
+ session.commit()
Review Comment:
For consistency and to ensure the database transaction is properly committed
when unpausing a backfill, the session.commit() is necessary in the
unpause_backfill function. Without it, the change to b.is_paused = False might
not be persisted to the database. Isn't my thought process right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
